Skip to content

Merge branch '4.6-pre-migration-staging' into crmsh-4.6 #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: crmsh-4.6
Choose a base branch
from

Conversation

nicholasyang2022
Copy link
Collaborator

No description provided.

@nicholasyang2022 nicholasyang2022 requested a review from zzhou1 May 16, 2025 06:22
@liangxin1300
Copy link
Collaborator

Please rebase the latest crmsh-4.6

nicholasyang2022 and others added 28 commits May 16, 2025 14:44
as migration is impossible without upgrading to SLES 16 first.
…c#PED-11808)

and advise to replace it with "fence_sbd".
@nicholasyang2022 nicholasyang2022 force-pushed the 4.6-pre-migration-staging branch from d5f4a23 to e5e2a1e Compare May 16, 2025 06:44
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 84.02778% with 46 lines in your changes missing coverage. Please review.

Project coverage is 67.26%. Comparing base (2ff0d7d) to head (e5e2a1e).

Files with missing lines Patch % Lines
crmsh/migration.py 84.16% 38 Missing ⚠️
crmsh/ui_cluster.py 78.37% 8 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.48% <84.02%> (+0.37%) ⬆️
unit 49.25% <31.94%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/cibquery.py 100.00% <100.00%> (ø)
crmsh/sh.py 93.22% <ø> (ø)
crmsh/xmlutil.py 69.27% <100.00%> (+0.03%) ⬆️
crmsh/ui_cluster.py 74.23% <78.37%> (-0.45%) ⬇️
crmsh/migration.py 84.16% <84.16%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants