Skip to content

Fix: Makefile.am: add python wheel target and .spec Recommends bash-completion #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

zzhou1
Copy link
Contributor

@zzhou1 zzhou1 commented May 16, 2025

Makefile.am:

  • add target to build Python wheel
  • fix an error when install tests
  • fix uninstall-local target with Python3 pip uninstall
  • install bash-completion

crmsh.spec.in:

  • Recommends bash-completion

@zzhou1 zzhou1 changed the title Fix: Makefile.am: add python wheel target and polish uninstall actions Fix: Makefile.am: add python wheel target and .spec Recommends bash-completion May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (db6ff2d) to head (3f53d6e).
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.52% <ø> (ø)
unit 52.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300
Copy link
Collaborator

@zzhou1 Please address the conflicts

zzhou1 added 3 commits May 21, 2025 12:04
- add target to build Python wheel
- fix an error when install tests
- fix uninstall-local target with Python3 pip uninstall

Signed-off-by: Roger Zhou <[email protected]>
@zzhou1 zzhou1 force-pushed the makefile-python-uninstall branch from 088d036 to 3f53d6e Compare May 21, 2025 04:10
@liangxin1300 liangxin1300 merged commit 3924dbf into ClusterLabs:master May 21, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants