fence_shelly: new fence agent for Shelly Gen2+ Switches #628
+366
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-628/1/input |
oalbrigt
reviewed
May 12, 2025
| "sw_id", | ||
| ] | ||
|
|
||
| all_opt["sw_id"] = { |
There was a problem hiding this comment.
You should use plug like we do for the other agents.
You can override "help" and "shortdesc" just like you've done for a couple of default values below.
Remember to run make xml-upload after and add the updated metadata to the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new Fence Agent for Shelly Gen 2+ Switch devices.
I wasn't 100% on
--plugflag intent, so I pulled in--sw-id(from shelly api) as a new param, but if they serve the same intent, should probably be unified.