LONDON | MAY2025 |FATMA_DEGIRMENCI | SPRINT2 | BOOK_LIBRARY #292
Conversation
…sistent using localStorage
fatmaevin
added
the
Needs Review
|
Can you check if any of this general feedback can help you further improve your code? Doing so can help me speed up the review process. Thanks. |
cjyuan
added
Reviewed
… .value usage removed
|
I tried to improve and adjust my code according to the feedback. Thank you. |
debugging/book-library/script.js
Outdated
| loadLibrary(); | ||
| if(myLibrary.length===0){ | ||
| populateStorage(); | ||
|
|
||
| } |
debugging/book-library/script.js
Outdated
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| checkInput.checked = false; |
There was a problem hiding this comment.
Could also consider using .reset() method of a form element.
debugging/book-library/script.js
Outdated
| function protectMyLibrary(){ | ||
| localStorage.setItem("myLibrary" , JSON.stringify(myLibrary)); | ||
| } |
There was a problem hiding this comment.
May I suggest naming the function saveLibrary? Since “save” and “load” are usually paired, this would make the naming more consistent.
debugging/book-library/script.js
Outdated
| function loadLibrary() { | ||
| const storedLibrary = localStorage.getItem("myLibrary"); | ||
| if (storedLibrary) { | ||
| myLibrary = JSON.parse(storedLibrary); |
There was a problem hiding this comment.
When a book is added to the array in submit() and populateStorage(), the code adds an instance of Book to the array.
On line 63, only the key–value pairs of the object are stored in the JSON-formatted string; the “prototype chain” of the Book object is not preserved. On line 69, the restored array therefore contains only plain objects, not Book instances.
In this app, it happens that a plain object works just as well as a Book instance.
In general, however, a more appropriate approach is to add code that converts the restored array into an array of Book instances.
…unctions for clarity,
fatmaevin
added
the
Needs Review
|
Changes look good! Well done! |
cjyuan
added
Complete
Self checklist