Skip to content

London | 25-ITP-May | Halimatou Saddiyaa | Sprint 3 | Programmer humour #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-May | Halimatou Saddiyaa | Sprint 3 | Programmer humour #304

wants to merge 4 commits into from

Conversation

Halimatou-saddiyaa
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I've implemented a programmer humour app with the following requirements:

  • The program gets the json using Fetch.
  • The function should make an API call to the given endpoint: https://xkcd.now.sh/?comic=latest
  • It should log the received data to the console
  • It should render the img property into an tag in the DOM
  • It should Incorporate error handling

Please review my PR.

Questions

Ask any questions you have for your reviewer.

@Halimatou-saddiyaa Halimatou-saddiyaa added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 18, 2025
LonMcGregor
LonMcGregor reviewed Aug 18, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this - the code and html works great. If you want to push yourself further, I've left a little remark about the styling

fetch/style.css
justify-content: center;
min-height: 100vh;
margin: 0;
padding: 20px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor issue: Be careful when using height and padding - on some devices this causes scrollbars which are unnecessary for the size of this webpage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified min-height to use dynamic viewport height(dvh) to avoid unnecessary scroll and use box-sizing: border-box to prevent padding increasing the overall height.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 18, 2025
@Halimatou-saddiyaa
Copy link
Author

Thanks for reviewing my PR @LonMcGregor . I've made the necessary changes, can you please check again?

@Halimatou-saddiyaa Halimatou-saddiyaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@LonMcGregor
Copy link

Good work - you are done with this sprint

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LonMcGregor LonMcGregor LonMcGregor left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Halimatou-saddiyaa @LonMcGregor