Skip to content

London | 25-ITP-May | Khilola Rustamova |Sprint 2| book library #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-May | Khilola Rustamova |Sprint 2| book library #310

wants to merge 3 commits into from

Conversation

HilolaRustam
Copy link

@HilolaRustam HilolaRustam commented Aug 16, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@HilolaRustam HilolaRustam added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 16, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

5 similar comments
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@HilolaRustam HilolaRustam changed the title LONDON | 25-ITP-MAY | KHILOLA RUSTAMOVA |SPRINT 2| book library London | 25-ITP-May | Khilola Rustamova |Sprint 2| book library Aug 16, 2025
@HilolaRustam HilolaRustam mentioned this pull request Aug 15, 2025
Open
cjyuan
cjyuan reviewed Aug 17, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2025
@HilolaRustam HilolaRustam added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 1 Assigned during Sprint 1 of this module Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2025
cjyuan
cjyuan reviewed Aug 17, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

debugging/book-library/script.js
alert("Please fill all fields correctly!");
return;
}
let book = new Book(title, author, Number(pages), readCheckBox.checked);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages could be a string resembling a number with decimal places.

debugging/book-library/script.js
Comment on lines +85 to 89
if(confirm(`Are you sure you want to delete " ${myLibrary[i].title}"?`)){
myLibrary.splice(i, 1);
render();
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the VSCode extension 'prettier' to auto indent JS code?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HilolaRustam @cjyuan