Skip to content

West Midlands | ITP 2025 MAY | Peter Lui | Sprint 2| Book Library #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West Midlands | ITP 2025 MAY | Peter Lui | Sprint 2| Book Library #312

wants to merge 4 commits into from

Conversation

petergmlui
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Initial submission

Questions

Ask any questions you have for your reviewer.

@petergmlui petergmlui added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 18, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module Data Flow) doesn't match expected format (example: 'Sprint 2', without quotes)

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module Data Flow) doesn't match expected format (example: 'Sprint 2', without quotes)

@petergmlui petergmlui changed the title West Midlands | ITP 2025 MAY | Peter Lui | Module Data Flow | Book Library West Midlands | ITP 2025 MAY | Peter Lui | Module Data Flow - Sprint 2| Book Library Aug 18, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module Data Flow - Sprint 2) doesn't match expected format (example: 'Sprint 2', without quotes)

@petergmlui petergmlui changed the title West Midlands | ITP 2025 MAY | Peter Lui | Module Data Flow - Sprint 2| Book Library West Midlands | ITP 2025 MAY | Peter Lui | Sprint 2| Book Library Aug 18, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2025
LonMcGregor
LonMcGregor reviewed Aug 18, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task - I've left some comments to point you to how to improve your solution

debugging/book-library/script.js Outdated
library.push(book);
render();
}
// console.log("submit() function called");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all this commented code is not needed, what impact does leaving it here have on the rest of the code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment doesn't affect code. its only for my own reading.

debugging/book-library/script.js
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
deleteCell.appendChild(delButton);
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about what normally happens when you delete a file on a computer. Is the behaviour here what you might expect? Can you think of any way to improve it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no requirement to implement an un-delete system. my code meets the requirement.

debugging/book-library/script.js Outdated
// read: check.checked
// });

// if (!title.value.trim() || !author.value.trim() || !pages.value || isNaN(parseInt(pages.value))) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have commented out the validation here - the form does some of it for you which is fine. But can you think of any edge cases where the "required" validation might not be enough?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is good advise. it was commented out during testing. i have put the check back in. thank you!

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 18, 2025
@petergmlui petergmlui added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025
@LonMcGregor
Copy link

Thanks for working on this

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@petergmlui petergmlui mentioned this pull request Aug 20, 2025
Open
@petergmlui
Copy link
Author

  • You have checked that the page count is a number, but should there be any limits on what the number can be?
    thanks - updated to clean comments and added max page check.

@LonMcGregor
Copy link

Great - The maximum might not be necessary, but the minimum is, Thanks for cleaning the comments. You are done with this sprint now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LonMcGregor LonMcGregor LonMcGregor left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petergmlui @LonMcGregor