Skip to content

Manchester | 25-ITP-May | Jennifer Isidienu | Sprint 2 | Book-Library #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Manchester | 25-ITP-May | Jennifer Isidienu | Sprint 2 | Book-Library #314

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0845e85
book-library-1
JenniferIsidienu Aug 19, 2025
0f1bfc9
Book-Library-2
JenniferIsidienu Aug 19, 2025
1edd203
html-book-library
JenniferIsidienu Aug 19, 2025
524d27c
html-corrected
JenniferIsidienu Aug 20, 2025
9438edd
Corrections-Book-Library
JenniferIsidienu Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>Book Library</title>
<meta
charset="utf-8"
name="viewport"
Expand Down
114 changes: 49 additions & 65 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}

window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
if (myLibrary.length === 0) {
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true);
myLibrary.push(book1, book2);
render();
}
}
Expand All @@ -25,79 +26,62 @@ const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
title.value.trim() === "" ||
author.value.trim() === "" ||
pages.value.trim() === ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do you want to keep leading and trailing space characters in title and author?

  • pages.value is a string, and it can be any string value accepted by the <input type="number"> element.

  • Consider pre-process/sanitize/normalize input and store them in some variables first, and reference the variables in other parts of the function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will make the corrections.

myLibrary.push(book);
render();
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
// Clear form
title.value = "";
author.value = "";
pages.value = "";
check.checked = false;
}
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);

// Clear all rows except the header
for (let i = table.rows.length - 1; i > 0; i--) {
table.deleteRow(i);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
myLibrary.forEach((book, i) => {
let row = table.insertRow(-1);
row.insertCell(0).innerText = book.title;
row.insertCell(1).innerText = book.author;
row.insertCell(2).innerText = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// Read status toggle button
let readCell = row.insertCell(3);
let readBtn = document.createElement("button");
readBtn.innerText = book.check ? "Yes" : "No";
readBtn.className = "btn btn-success";
readBtn.addEventListener("click", function () {
book.check = !book.check;
render();
});
readCell.appendChild(readBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
// Delete button
let deleteCell = row.insertCell(4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of the pros and cons of these two approaches for creating cells within a row?

  • Keeping all the cell creation code in one location, like the original code does.
  • Scattering the cell creation code across different locations, like what you did.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it in one location will make it easier to read. I'll correct mine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "keeping all cell creation code in one location", I meant

    row.insertCell(0).innerText = book.title;
    row.insertCell(1).innerText = book.author;
    row.insertCell(2).innerText = book.pages;
    
    // Could use const instead of let
    const readCell = row.insertCell(3);        
    const deleteCell = row.insertCell(4);
    
    ...

This way, it is easy to find out there are 5 cells created.

let deleteBtn = document.createElement("button");
deleteBtn.innerText = "Delete";
deleteBtn.className = "btn btn-warning";
deleteBtn.addEventListener("click", function () {
alert(`You've deleted title: ${book.title}`);
myLibrary.splice(i, 1);
render();
});
}
deleteCell.appendChild(deleteBtn);
});
}