Skip to content

West Midlands| 25-ITP-May | Emin Akturk | Module Data Flows | Book Library #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

West Midlands| 25-ITP-May | Emin Akturk | Module Data Flows | Book Library #316

wants to merge 1 commit into from

Conversation

eminakturk
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@eminakturk eminakturk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@eminakturk eminakturk changed the title EMIN AKTURK | BIRMINGHAM | BOOK LIBRARY EMIN AKTURK | BIRMINGHAM | BOOK-LIBRARY Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@sambabib sambabib added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

sambabib
sambabib reviewed Aug 20, 2025
View reviewed changes
debugging/book-library/script.js
@@ -76,7 +83,7 @@ function render() {
changeBut.className = "btn btn-success";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wherever you can, naming variables so its use case is easily inferred is always a good idea. for example, changeBut here could be changeButton but I understand this was in the starter code so it isn't your fault, it is just something to note.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job debugging overall!

@sambabib sambabib added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@eminakturk eminakturk changed the title EMIN AKTURK | BIRMINGHAM | BOOK-LIBRARY West Midlands | MAY | EMIN AKTURK | BOOK LIBRARY Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@eminakturk eminakturk changed the title West Midlands | MAY | EMIN AKTURK | BOOK LIBRARY West Midlands | MAY | EMIN AKTURK - BOOK LIBRARY Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@eminakturk eminakturk changed the title West Midlands | MAY | EMIN AKTURK - BOOK LIBRARY EMIN AKTURK | BIRMINGHAM | MAY | DEBUGGING | BOOK-LIBRARY Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

@eminakturk eminakturk changed the title EMIN AKTURK | BIRMINGHAM | MAY | DEBUGGING | BOOK-LIBRARY EMIN AKTURK | WEST MIDLANDS | MAY | DEBUGGING | BOOK-LIBRARY Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

@eminakturk eminakturk changed the title EMIN AKTURK | WEST MIDLANDS | MAY | DEBUGGING | BOOK-LIBRARY West Midlands| 25-ITP-May | Emin Akturk | Book Library Aug 20, 2025
@eminakturk eminakturk changed the title West Midlands| 25-ITP-May | Emin Akturk | Book Library West Midlands| 25-ITP-May | Emin Akturk | Module Data Flows | Book Library Aug 20, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module Data Flows) doesn't match expected format (example: 'Sprint 2', without quotes)

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module Data Flows) doesn't match expected format (example: 'Sprint 2', without quotes)

@eminakturk eminakturk mentioned this pull request Aug 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sambabib sambabib sambabib left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eminakturk @sambabib