London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Java script challenges #317

HoussamLh · 2025-08-20T17:40:19Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Title:
Complete JS and Unit Testing Challenges

Description:
This PR merges all completed katas and JS exercises, including:

Factorial, Car Sales, Average, Largest Number, Remove Vowels, Roman Numerals, Password Verifier, String Calculator

Cowsay CLI, Weather App, Dog Photo Gallery

All Jest tests pass for katas
Browser projects work with expected functionality
Modular, tested, and ready for review

Question

Are there ways to make my test-writing and implementation more efficient?
Are there any best practices I should follow when structuring my functions and test files?
How can I improve the readability and maintainability of my code for these katas?

- Accepts command-line arguments - Displays a speech bubble around the input - Shows a simple ASCII cow below the bubble - Defaults to "Moo!" if no input is provided

- Uses readline to prompt the user for input - Displays a speech bubble around the input - Shows a simple ASCII cow below the bubble - Defaults to "Moo!" if no input is provided

…ather app. - Add app.js with placeholders for OpenWeather and Unsplash API keys. - Fetch weather data from OpenWeather and display temperature and description. - Fetch images from Unsplash based on weather description and display main image. - Add clickable thumbnails that update main photo and photographer credit. - Implement search form to update weather and images for user-entered city. - Add try/catch to handle API errors and display error message in UI. - Insert real OpenWeather and Unsplash API keys into app.js.

- Added heading, "Add Dog" button, "Clear Gallery" button - Added empty <ul> for dog images - Linked external app.js script - Basic CSS for layout, buttons, and gallery styling

- Added async function to fetch from https://dog.ceo/api/breeds/image/random - Created <li> and <img> for each new dog image - Appended dog images to gallery dynamically - Added error handling with alert and console error

- Added event listener to clear-gallery button - Clears all <li> dog images from the gallery - Keeps app simple and easy to reset - Add some css style

- return 0 when input is an empty string - handle single number input - support summing two numbers - allow summing an unknown amount of numbers - ignore numbers greater than 1000 - throw error when negative numbers are passed

- Reject password if it is shorter than 8 characters - Reject password if it is null - Reject password if it has no uppercase letter - Reject password if it has no number - Return 'Password accepted' when all rules are satisfied

- implement simple mapping for numbers 1 to 10 - add first test for 1 → I - add tests for 5 → V and 10 → X

- implement basic old Roman numeral mapping for numbers 1–10 - add first test for 1 → I - add tests for 4 → IIII, 5 → V, 8 → VIII, and 10 → X

- implement sales function to calculate total price per make - add test for sample carsSold array

- implement factorial function using iterative approach

- implement average function to calculate average of numbers only - add test for mixed array of numbers and strings

- implement getLargestNumber function to find largest number in array - add test to check largest number and ensure original array is unchanged

- implement removeVowels function to remove vowels from a single word - implement removeVowelsFromWords to remove vowels from all words in an array - add test to check array of words against expected vowel-free output

sambabib · 2025-08-23T08:46:58Z

challenges/challenge-cowsay-two/solution1.js

-
-// 3. Make a cow that takes a string
+// 3. Make a simple cow
+function makeCow() {


curious. how did you get the image of the cow?

sambabib · 2025-08-23T08:48:07Z

challenges/challenge-cowsay-two/solution2.js

-// 2. Make supplies for our speech bubble
-
-// 3. Make a cow that takes a string
+function makeBubble(text) {


the implementation of the bubble is clever.

sambabib · 2025-08-23T09:30:16Z

challenges/challenge-weather-app/app.js

+// ====================
+
+// Your working API keys
+const WEATHER_API_KEY = "13940029dbb0ac27fa8e76f770798f71"; 


it is generally not good practice to commit secrets/keys to source control. I'm not sure if this was the recommended approach but it is something to note moving forward. you should look up environment variables. In a situation where you have environment variables set, I would need to create my own keys to test your application, so leaving your keys here makes testing/iterating quicker. but this is something to always keep in mind as you go.

sambabib · 2025-08-23T09:33:52Z

challenges/challenge-weather-app/app.js

+const UNSPLASH_ACCESS_KEY = "1EkJLQ64exkT3BxWkvtunY6nGsyoUpmmVOIycUfobC4";
+
+// DOM elements
+const photoEl = document.getElementById("photo");


while I can tell what this variable name does by just looking at it, you should look to have more descriptive variable names. so, photoElement or photoContainer reads better than just photoEl. searchForm and searchInput are very clear and their use case can be inferred at first glance, so keep the clarity consistent.

sambabib · 2025-08-23T09:43:30Z

challenges/challenge-weather-app/app.js

+async function getWeather(city = "London") {
+    const url = `https://api.openweathermap.org/data/2.5/weather?q=${city}&appid=${WEATHER_API_KEY}&units=metric`;
+    const res = await fetch(url);
+    if (!res.ok) throw new Error("Invalid API key or city");


good response check here. however, the error description may have nothing to do with why the fetch request has failed. it could be a server timeout, it could be a 404 not found, it could be anything. but your returned description assumes that it is either the api key or city. if you want to match the error with the description, you would need to handle different response status codes.

therefore, if you want to use a generic response here, you would be doing something like:

if (!res.ok) { throw new Error(`request failed with status ${res.status} (${res.statusText})`); }

sambabib · 2025-08-23T10:17:33Z

challenges/challenge-weather-app/app.js

+}
+
+// Load default city
+updateCity("London");


your code says async function getWeather(city = "London"), if you are passing "London" as a parameter to the getWeather function then having city = "London" in the function declaration is redundant. it's not the end of the world btw. your implementation is very good, you only need to do getWeather(city) and then pass "London" as a parameter so it loads as your default city.

sambabib · 2025-08-23T10:20:08Z

challenges/dog-photo-gallery/script.js

+  try {
+    const response = await fetch("https://dog.ceo/api/breeds/image/random");
+    if (!response.ok) {
+      throw new Error(`HTTP error! Status: ${response.status}`);


see (from my comments in the weather app), you have handled the !response.ok excellently here.

sambabib · 2025-08-23T16:39:52Z

challenges/unit-testing/katas-tdd/calculator/calculator.test.js

+
+  test("should return sum of two numbers", () => {
+    expect(add("3,6")).toBe(9);
+  });


very good add function and well-written tests. no notes.

sambabib · 2025-08-23T19:38:48Z

challenges/unit-testing/passing-tests/get-average/get-average.js


-function average(numbers) {}
+  if (numsOnly.length === 0) return 0;


sambabib · 2025-08-23T19:41:12Z

challenges/unit-testing/writing-tests/remove-vowels/remove-vowels-in-array.js

-  });
-
-  return result;
+  return words.map(word => removeVowels(word));


cleaner. very good

HoussamLh added 18 commits August 20, 2025 15:49

- add stripped-down cowsay CLI.

240363a

- Accepts command-line arguments - Displays a speech bubble around the input - Shows a simple ASCII cow below the bubble - Defaults to "Moo!" if no input is provided

- Add interactive cowsay CLI using readline

fcddc49

- Uses readline to prompt the user for input - Displays a speech bubble around the input - Shows a simple ASCII cow below the bubble - Defaults to "Moo!" if no input is provided

- Add base HTML with buttons and gallery container

5f529e0

- Added heading, "Add Dog" button, "Clear Gallery" button - Added empty <ul> for dog images - Linked external app.js script - Basic CSS for layout, buttons, and gallery styling

- Implement fetchDogImage with Dog API

95f0aaf

- Added async function to fetch from https://dog.ceo/api/breeds/image/random - Created <li> and <img> for each new dog image - Appended dog images to gallery dynamically - Added error handling with alert and console error

- Add clear gallery button functionality

01b4bca

- Added event listener to clear-gallery button - Clears all <li> dog images from the gallery - Keeps app simple and easy to reset - Add some css style

- setup project with Jest for unit testing

38caffc

- return 0 when input is an empty string - handle single number input - support summing two numbers - allow summing an unknown amount of numbers - ignore numbers greater than 1000 - throw error when negative numbers are passed

- Setup project with Jest for password verifier tests

94fecf5

- Reject password if it is shorter than 8 characters - Reject password if it is null - Reject password if it has no uppercase letter - Reject password if it has no number - Return 'Password accepted' when all rules are satisfied

- setup project with script.js and test.js for Roman numeral converter

cb4209c

- implement simple mapping for numbers 1 to 10 - add first test for 1 → I - add tests for 5 → V and 10 → X

- setup project with convert-to-old-roman.js and test file

8464e8f

- implement basic old Roman numeral mapping for numbers 1–10 - add first test for 1 → I - add tests for 4 → IIII, 5 → V, 8 → VIII, and 10 → X

- setup project with car-sales.js and test file

9df60a0

- implement sales function to calculate total price per make - add test for sample carsSold array

- Add some changes on the files names to make sure the test passed well.

b2d41e2

- Delete the wrong files

13aedf1

- setup project with factorial.js and test file

935adda

- implement factorial function using iterative approach

- setup project with get-average.js and test file

b4029f0

- implement average function to calculate average of numbers only - add test for mixed array of numbers and strings

- add some improvement to the code to make the test work

2f4c247

- setup project with largest-number.js and test file

2c324be

- implement getLargestNumber function to find largest number in array - add test to check largest number and ensure original array is unchanged

- setup project with remove-vowels.js and remove-vowels-in-array.js

4cef7e5

- implement removeVowels function to remove vowels from a single word - implement removeVowelsFromWords to remove vowels from all words in an array - add test to check array of words against expected vowel-free output

HoussamLh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2025

sambabib added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 23, 2025

sambabib reviewed Aug 23, 2025

View reviewed changes

sambabib added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Java script challenges #317

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Java script challenges #317

Uh oh!

HoussamLh commented Aug 20, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

sambabib Aug 23, 2025

Uh oh!

Uh oh!


		function average(numbers) {}
		if (numsOnly.length === 0) return 0;

Uh oh!

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Java script challenges #317

Are you sure you want to change the base?

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Java script challenges #317

Uh oh!

Conversation

HoussamLh commented Aug 20, 2025

Learners, PR Template

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!