London | 25-SDC-July | Aung Ye Kyaw | sprint 3|Implementation shell tools exercise #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarawone
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 19, 2025
There was a problem hiding this comment.
Good start on this sprint, but there are some issues with your pull request that need to be fixed:
- Can you check that all your implemented .js files are in the correct directories? (Hint: check cat)
- Can you remove the .DS_Store files - these are only relevant for mac devices and shouldn't be committed
- Your implementations all take only a single argument. Try running the originals with a wildcard argument, and compare to your own.
- When I run your files I get a warning message saying
Warning: Module type of file- do you get this on your system? Is there something that needs to be added or changed to hide this?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I wish you a good day.
I would like to thank you for the time to review my coursework.
Kindly check and provide feedback & guide..
Thanks ,
AYK