Cape Town| 25-SDC-July | Faith Muzondo | Sprint 4| Implement shell tools python #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faithy4444
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Aug 25, 2025
There was a problem hiding this comment.
Hi,
You committed files that were not part of this PR - please be careful of that. Can you remove these from the "changed files" please?
Remember to update the default PR text when submitting on github.
Good work implementing the tasks - I have left some comments where you could improve further
There was a problem hiding this comment.
Try running the original cat program and comparing your output, do you see any differences?
Also, there is some code duplication in here, can you figure out how to clean that up?
There was a problem hiding this comment.
There is some duplication of code here - can you think how to reduce this?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.