generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 27
Cape Town| 25-SDC-July | Faith Muzondo | Sprint 4| Implement cowsay #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Faithy4444
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
Faithy4444:implement-cowsay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1fa1221
script 1 to 3
Faithy4444 cfd20f9
implement cowsay complete
Faithy4444 dc469dd
Remove unwanted files, keep only main.py and requirements.txt
Faithy4444 b90ef41
validation using argparse
Faithy4444 28ac4c3
validation fixed
Faithy4444 256a427
Remove launch.json from repo
Faithy4444 993862d
Remove unrelated shell script files from PR
Faithy4444 3746edc
animal made optional
Faithy4444 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import cowsay | ||
import argparse | ||
|
||
parser = argparse.ArgumentParser(prog="cowsay", description="displays cowsay charactor with given arguments") | ||
parser.add_argument('--animal', choices=cowsay.char_names, default="cow", help= 'please enter a valid animal') | ||
parser.add_argument('message', nargs="+", help= 'please enter a message') | ||
arg = parser.parse_args() | ||
|
||
msg = " ".join(arg.message) | ||
animal_func = getattr(cowsay, arg.animal) | ||
print(animal_func(msg)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
cowsay |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: you don't need to use print here as your
animal_func
already prints the message. Because of the extra print you getNone
at the end.