London | 25-SDC-July | Priscilla Emebo | Sprint 3 | Implement shell tools #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Priscilla-EM
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 19, 2025
| program | ||
| .name("myls") | ||
| .description("list file(s) in the directory, like the ls command") | ||
| .option("-1", "list one file per line") |
There was a problem hiding this comment.
Think about what the purpose of the -1 option here is. Have you missed something in your implementation?
| options.c = true; | ||
| } | ||
|
|
||
| const showLines = options.l; |
There was a problem hiding this comment.
Why are you creating new variables here which are the same as accessing the options dictionary?
| totalBytes += byteCount; | ||
|
|
||
| let output = ""; | ||
| if (showLines) output += `${lineCount.toString().padStart(8)}`; |
There was a problem hiding this comment.
There is duplication here when you are printing your outputs, can you think how to solve that?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.