Skip to content

London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implement shell tool python #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implement shell tool python #154

wants to merge 2 commits into from

Conversation

eyuell21
Copy link

@eyuell21 eyuell21 commented Aug 7, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@eyuell21 eyuell21 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 7, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 19, 2025
LonMcGregor
LonMcGregor reviewed Aug 19, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these tasks so far, I've left some pointers to get you started on improvements

implement-shell-tools/cat/my_cat.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the formatting of the output might not be working quite right. Can you find out why and fix it?

(Hint: Try running with a wildcard for all the files in the sample directory)

implement-shell-tools/ls/my_ls.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good implementation, but I think you might have misread -1 in the readme as -l. You can keep -l, which is a good stretch task, but can you add the implementation for -1 as well?

implement-shell-tools/wc/my_wc.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation works well but you might be able to improve your code:

  • Is there a reason you create variables that store data that is already stored in the args dictionary?
  • Can you see where there is duplication in your code. Can you fix that?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LonMcGregor LonMcGregor LonMcGregor left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyuell21 @LonMcGregor