Skip to content

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 4 | Cowsay Implementation #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 4 | Cowsay Implementation #160

wants to merge 2 commits into from

Conversation

Mikiyas-STP
Copy link

@Mikiyas-STP Mikiyas-STP commented Aug 11, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Mikiyas-STP Mikiyas-STP added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 19, 2025
LonMcGregor
LonMcGregor reviewed Aug 19, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the default PR text when submitting on github.

Good work on this sprint. If you update your PR text, I can approve this sprint as done

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 19, 2025
@Mikiyas-STP
Copy link
Author

Remember to update the default PR text when submitting on github.

Good work on this sprint. If you update your PR text, I can approve this sprint as done

Hi @LonMcGregor What is a PR text ? is it how i name my PR?

@LonMcGregor
Copy link

At the top of this page on github, you have the PR description. This is used to tell the reviewer what the code is and what you want reviewed. Right now, you can see it contains only the default "Briefly explain your PR."

Can you edit it to add your own thoughts and plans for this Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LonMcGregor LonMcGregor LonMcGregor left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikiyas-STP @LonMcGregor