-
-
Notifications
You must be signed in to change notification settings - Fork 96
Add next-class-day-plan shortcode and wire to ITP index (fixes #1119) #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
Thanks for putting this together! It generally looks reasonable, but one thing I'm not sure about is the As far as I can tell, this pull request doesn't create a menu called scheduled - what's meant to be in it? It looks like it's meant to be each sprint? We already have a menu called "syllabus" which contains each module, and then a menu_level called "module" which contains each sprint within a module - could we use these existing menus, rather than having to introduce another one? |
What does this change?
Common Content?
Common Theme?
Issue number: #1119
Org Content?
Checklist
Who needs to know about this?
Please review: @SallyMcGrath
Before / After (artifacts)
Before
org-cyf-itp/content/_index.md
(pre-change)After
common-theme/layouts/shortcodes/next-class-day-plan.html
org-cyf-itp/content/_index.md
Notes
org-cyf-itp/content/_index.md
using{{< next-class-day-plan >}}
.failed to render shortcode "next-class-day-plan"
, ensure the shortcode file path is exactlycommon-theme/layouts/shortcodes/next-class-day-plan.html
and that the partials it calls (if any) exist at the expected paths.