Preview 1.82.21 Update (Vuln CVE-2025-24070) #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100% reviewed source file: 'en_US.json' on 'zh_CN'.
Change QD branch to main
This caused by duplicated entries on the check, causing the launcher to check every entries on both primary and game-res manifests.
This reverts commit 290b1a9.
+ Add new default background sprites for each regions
This reverts commit 9578fc5.
* Add Anisotropic Sampling option to ZZZ GSP AKA Anisotropic Filtering, but kept the in-game name for clarity. All presets seem to not change the value, keeping it at x8. * Changes based on feedback #703 (review)
There was a problem hiding this comment.
Pull Request Overview
This PR updates several components to address security vulnerabilities and improve functionality, including a .NET version bump for CVE-2025-24080, fixes for various UI and functionality issues, and the addition of anisotropic filtering options for the Zenless game settings. Key changes include:
- Adding support for anisotropic filtering in language and game settings.
- Refactoring manifest fetching logic to use an alternate lookup dictionary.
- Updating proxy configuration to support SecureString passwords and improving string null checks in playtime management.
Reviewed Changes
Copilot reviewed 25 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Hi3Helper.Core/Lang/Locale/LangZenlessGameSettingsPage.cs | Adds a property for anisotropic filtering language string. |
| CollapseLauncher/XAMLs/MainApp/Pages/GameSettingsPages/ZenlessGameSettingsPage.Ext.cs | Configures the anisotropic filtering selector. |
| CollapseLauncher/Classes/RepairManagement/Zenless/ZenlessRepair.Fetch.cs | Switches to an alternate lookup dictionary for assets. |
| CollapseLauncher/Classes/RepairManagement/Zenless/ZenlessRepair.Extensions.cs | Updates helper methods to use alternate lookup for assets. |
| CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.cs | Updates status flags in completeness status updates. |
| CollapseLauncher/Classes/Helper/SimpleProtectData.cs | Adds a method to unprotect a string into a SecureString. |
| CollapseLauncher/Classes/Helper/HttpClientBuilder.cs | Adapts proxy configuration to use SecureString for passwords. |
| CollapseLauncher/Classes/GameManagement/GameSettings/Zenless/FileClass/GeneralData.cs | Adds anisotropic sampling game setting. |
| CollapseLauncher/Classes/GameManagement/GameSettings/Zenless/Enums.cs | Defines the new anisotropic sampling enum. |
| CollapseLauncher/Classes/GameManagement/GamePlaytime/RegistryClass/CollapsePlaytime.cs | Refines string checks and logical conditions for playtime updates. |
| .github/workflows/qodana-scan.yml, qodana-scan-pr.yml, .github/workflows/build.yml | Updates .NET version and Qodana scan configuration. |
Files not reviewed (7)
- CollapseLauncher/CollapseLauncher.csproj: Language not supported
- CollapseLauncher/XAMLs/MainApp/Pages/GameSettingsPages/ZenlessGameSettingsPage.xaml: Language not supported
- CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml: Language not supported
- CollapseLauncher/packages.lock.json: Language not supported
- ColorThief: Language not supported
- H.NotifyIcon: Language not supported
- Hi3Helper.Core/Lang/zh_CN.json: Language not supported
CollapseLauncher/Classes/RepairManagement/Zenless/ZenlessRepair.Extensions.cs
Show resolved
Hide resolved
neon-nyan
changed the title
|
ACK'd by @neon-nyan via Discord VC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed? - 1.82.21
Templates
Changelog Prefixes