-
Notifications
You must be signed in to change notification settings - Fork 0
Remove ActiveRecord::Dirty usage #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pimpin
wants to merge
14
commits into
master
Choose a base branch
from
fix_save_return_for_nested
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−9
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
650ecdd
Add failing test to reproduce the unexpected behaviour
pimpin 1f7ac04
remove Active Model dirty
pimpin a5ec52a
dirty fix with a reload
pimpin fa9bca5
remove dirty fix
pimpin 53f052e
Working but strange implemntation.
pimpin a181cfc
Fix weird implem
pimpin 3d71024
Apply precision on timestamp for any input type
pimpin a5feceb
cleannup
pimpin 0765ab9
Rm comments
pimpin 7e725e3
Merge remote-tracking branch 'origin/master' into fix_save_return_for…
JulienBURNET-FAUCHE ecdc128
Merge branch 'master' into fix_save_return_for_nested
pimpin 5c56c77
undo unwanted changes
pimpin b4a6280
undo unwanted change
pimpin 9153062
Fix type casting and precision issues
pimpin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,6 @@ def move_changes | |
|
||
def changes_applied | ||
move_changes | ||
super | ||
end | ||
|
||
def reset_object! | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of
.floor
calls changes the behavior of timestamp casting by truncating subsecond precision. This could be a breaking change for consumers expecting microsecond precision in timestamps. Consider documenting this behavioral change or making it configurable.Copilot uses AI. Check for mistakes.