Skip to content

Bumping major versions, and fixing tags for tests #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

msaperst
Copy link
Contributor

Addresses #234

@@ -80,6 +80,7 @@ public static String removeNonWordCharacters(String value) {
* @return String: a unique name
*/
public static String getTestName(Method method, Object... dataProvider) {
//TODO - look at making use of new setTestName and getFactoryParameters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Complete the task associated to this TODO comment. rule

@coveros-ci-dev
Copy link

SonarQube analysis reported 10 issues

  • MINOR 2 minor
  • INFO 8 info

Watch the comments in this conversation to review them.

9 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR com.coveros:selenified: URI: http://localhost:1070/next_page.html?submit_button=Submit | Method: GET | Attack: GET | URI: http://localhost:1070/next_page.html | Method: GET | Attack: GET | URI: http://localhost:1070/ | Method: GET | Attack: GET | Confidence: 2 | Description:

    The Content-Type header was either missing or empty.

    | rule
  2. MINOR com.coveros:selenified: URI: http://localhost:1070/ | Method: GET | Param: X-Content-Type-Options | Attack: GET | URI: http://localhost:1070/next_page.html | Method: GET | Param: X-Content-Type-Options | Attack: GET | URI: http://localhost:1070/next_page.html?submit_button=Submit | Method: GET | Param: X-Content-Type-Options | Attack: GET | Confidence: 2 | Description:

    The Anti-MIME-Sniffing header X-Content-Type-Options was not set to 'nosniff'. This allows older versions of Internet Explorer and Chrome to perform MIME-sniffing on the response body, potentially causing the response body to be interpreted and displayed as a content type other than the declared content type. Current (early 2014) and legacy versions of Firefox will use the declared content type (if one is set), rather than performing MIME-sniffing.

    | rule
  3. INFO com.coveros:selenified: Filename: selenium-opera-driver-3.141.59.jar | Highest CVSS Score: 10.0 | Amount of CVSS: 15 | References: CVE-2008-3079 (10.0) CVE-2008-4293 (10.0) CVE-2008-1761 (9.3) CVE-2008-1764 (9.3) CVE-2008-4695 (9.3) CVE-2008-4794 (9.3) CVE-2008-5679 (9.3) CVE-2015-8960 (8.1) CVE-2010-5227 (6.9) CVE-2008-3172 (6.8) CVE-2009-0915 (6.8) CVE-2019-19788 (5.5) CVE-2003-1561 (4.3) CVE-2008-4696 (4.3) CVE-2008-4795 (4.3) rule
  4. INFO com.coveros:selenified: Filename: okhttp-3.11.0.jar | Highest CVSS Score: 5.9 | Amount of CVSS: 1 | References: CVE-2018-20200 (5.9) rule
  5. INFO com.coveros:selenified: Filename: htmlunit-core-js-2.36.0.jar | Highest CVSS Score: 4.4 | Amount of CVSS: 1 | References: CVE-2010-3359 (4.4) rule
  6. INFO com.coveros:selenified: Filename: neko-htmlunit-2.36.0.jar | Highest CVSS Score: 4.4 | Amount of CVSS: 1 | References: CVE-2010-3359 (4.4) rule
  7. INFO com.coveros:selenified: Filename: commons-compress-1.18.jar | Highest CVSS Score: 7.5 | Amount of CVSS: 1 | References: CVE-2019-12402 (7.5) rule
  8. INFO com.coveros:selenified: Filename: selenium-server-3.141.59.jar: jquery-3.1.1.min.js | Highest CVSS Score: 6.1 | Amount of CVSS: 1 | References: CVE-2019-11358 (6.1) rule
  9. INFO com.coveros:selenified: Filename: jetty-repacked-9.4.12.v20180830.jar (shaded: org.eclipse.jetty:jetty-server:9.4.12.v20180830) | Highest CVSS Score: 6.1 | Amount of CVSS: 2 | References: CVE-2019-10241 (6.1) CVE-2019-10247 (5.3) rule

@msaperst msaperst merged commit 6675eed into develop Jan 14, 2020
@msaperst msaperst deleted the feature/versionBump branch January 14, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants