Skip to content

Feat: jira integration #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Feat: jira integration #3002

wants to merge 24 commits into from

Conversation

mbani01
Copy link

@mbani01 mbani01 commented Apr 18, 2025

Changes proposed ✍️

What

Migrate Jira migration to Nango

Why

The current Jira implementation is broken

How

BACKEND (@skwowet & @epipav please check backend changes):

Preparing API to use nango for Jira, using their 3 integrations:

  1. jira-basic (Cloud)
  2. jira-data-center-basic
  3. jira-data-center-api-key

PS: I had to adjust some core functions to support the mapping between our Jira and Nango's Jira. This is because Nango treats each auth flow as a separate integration, while we have a single Jira integration that supports all those auth methods.

FRONTEND (@Sameh16 & @gaspergrom please check frontend changes):

  1. Enable Jira to allow new connections (I just reverted the old implementation before disabling Jira)
  2. Remove Jira from the warning message in the banner and keep Confluence only

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@mbani01 mbani01 requested a review from themarolt April 22, 2025 15:21
@mbani01 mbani01 marked this pull request as ready for review April 22, 2025 15:21
@mbani01 mbani01 force-pushed the feature/jira_integration branch from d9f66ec to d0cc822 Compare April 28, 2025 12:36
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.

@mbani01 mbani01 changed the title Feature/jira integration Feat: jira integration Apr 28, 2025
Copy link
Collaborator

@Sameh16 Sameh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for UI part

Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one nitpick, other than that lgtm 👍

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.

@@ -152,6 +152,12 @@ const en = {
git: {
noIntegration: 'The Git integration is not configured.',
},
jira: {
invalidUrl:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont use translations anymore so in further prs you can also include directly in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants