-
Notifications
You must be signed in to change notification settings - Fork 737
Feat: jira integration #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: jira integration #3002
Conversation
Signed-off-by: Uroš Marolt <[email protected]> Co-authored-by: Joana Maia <[email protected]>
… adjust dependencies
d9f66ec
to
d0cc822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for UI part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added one nitpick, other than that lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
@@ -152,6 +152,12 @@ const en = { | |||
git: { | |||
noIntegration: 'The Git integration is not configured.', | |||
}, | |||
jira: { | |||
invalidUrl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use translations anymore so in further prs you can also include directly in code.
Changes proposed ✍️
What
Migrate Jira migration to Nango
Why
The current Jira implementation is broken
How
BACKEND (@skwowet & @epipav please check backend changes):
Preparing API to use nango for Jira, using their 3 integrations:
PS: I had to adjust some core functions to support the mapping between our Jira and Nango's Jira. This is because Nango treats each auth flow as a separate integration, while we have a single Jira integration that supports all those auth methods.
FRONTEND (@Sameh16 & @gaspergrom please check frontend changes):
Checklist ✅
Feature
,Improvement
, orBug
.