Implement responsive design #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything looks good to me! Just a minor suggestion: the input bar on the registration page appears a bit thin on some mobile devices—for example, the iPhone 14 Pro Max (see screenshot below). |
dchiller
approved these changes
Jun 19, 2025
| {% endif %} | ||
| <!-- Mobile background image (visible only on small screens) --> | ||
| <div class="d-md-none position-absolute top-50 start-50 translate-middle z-0 w-100 h-100 d-flex justify-content-center align-items-center"> | ||
| <img src="{% static "assets/images/sign-up.svg" %}" alt="" class="img-fluid opacity-50 w-100 h-100" style="max-width: 80%; max-height: 80%;" /> |
There was a problem hiding this comment.
Suggested change
| <img src="{% static "assets/images/sign-up.svg" %}" alt="" class="img-fluid opacity-50 w-100 h-100" style="max-width: 80%; max-height: 80%;" /> | |
| <img src="{% static "assets/images/sign-up.svg" %}" alt="" class="opacity-50 w-100 h-100" style="max-width: 80%; max-height: 80%;" /> |
I think this is overriden by other attributes.
Comment on lines
16
to
20
| {% block right_column %} | ||
| {% endblock right_column %} | ||
|
|
||
| {% block mobile_link %} | ||
| {% endblock mobile_link %} |
There was a problem hiding this comment.
In this and analogous files, you don't need these blocks, I don't think, if you aren't overriding base (which is currently empty).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #191