Skip to content

feat: fix the style of no data in empty #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

xiaoxiwer
Copy link
Contributor

@xiaoxiwer xiaoxiwer commented Dec 4, 2024

变更类型

请选择以下选项以描述 PR 的类型:

  • Bug 修复(修复现有问题)
  • 新功能(添加了一个功能)
  • 代码优化(性能改进、代码重构)
  • 文档更新
  • 单测新增或修改
  • 其他(请说明):

相关问题

#514
当empty组件中type属性为search时变更图标为动态的

变更内容

变更empty组件type属性的图标样式

详细描述

变更empty组件type属性的图标样式

对应 Previewer

Previewer

Copy link
Collaborator

@LuckyFBB LuckyFBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 demo 中增加对应的样例,贴一个 previewer

Copy link
Collaborator

@LuckyFBB LuckyFBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要和 ui 确认是否以前的 search 不再使用,全部更改成为动态的
image

Copy link
Collaborator

@LuckyFBB LuckyFBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加一个单元测试吧

@LuckyFBB LuckyFBB merged commit 4aca82b into DTStack:master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants