-
Notifications
You must be signed in to change notification settings - Fork 49
add custom extent prop for geomap widget #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add custom extent prop for geomap widget #2602
Conversation
"focus": "focus", | ||
} | ||
|
||
def __init__(self_, focus: str, **kwargs): | ||
def __init__(self_, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): | |
def __init__(self, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
0fe7558
to
c49361c
Compare
eb20773
to
d2de444
Compare
d2de444
to
3aaefc3
Compare
3aaefc3
to
a159d93
Compare
"focus": "focus", | ||
} | ||
|
||
def __init__(self_, focus: str, **kwargs): | ||
def __init__( | ||
self_, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs | |
self, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
See DataDog/datadog-api-spec#3923
Test branch datadog-api-spec/test/victor.wei/DEX-114/add_custom_extent_to_tiledef