Skip to content

Mhlidd/test ci #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Mhlidd/test ci #5814

wants to merge 49 commits into from

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Jun 3, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

BridgeAR and others added 30 commits April 23, 2025 16:02
This is needed to set environment variables during runtime. We
likely have to think of alternatives.
Using the proxy and the getter/setter pair was more complex and the
user could theoretically have written code that would have worked
around it. This also prevents the additional proxy overhead when
using process.env.
This also addresses issues found with the stricter linter
Copy link

github-actions bot commented Jun 3, 2025

Overall package size

Self size: 9.62 MB
Deduped: 104.56 MB
No deduping: 105.08 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (2531473) to head (5445deb).

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/cucumber.js 0.00% 3 Missing ⚠️
packages/datadog-instrumentations/src/mocha.js 0.00% 2 Missing ⚠️
...ackages/datadog-instrumentations/src/mocha/main.js 0.00% 2 Missing ⚠️
packages/datadog-plugin-cucumber/src/index.js 0.00% 2 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js 0.00% 1 Missing ⚠️
packages/dd-trace/src/llmobs/sdk.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
- Coverage   79.16%   78.51%   -0.65%     
==========================================
  Files         522      323     -199     
  Lines       24060    13390   -10670     
==========================================
- Hits        19046    10513    -8533     
+ Misses       5014     2877    -2137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 3, 2025

Datadog Report

Branch report: mhlidd/test_Ci
Commit report: e5616b4
Test service: dd-trace-js-integration-tests

❌ 8 Failed (0 Known Flaky), 1192 Passed, 0 Skipped, 16m 31.27s Total Time

❌ Failed Tests (8)

This report shows up to 5 failed tests.

  • [email protected] commonJS impacted tests test is not new should not be detected as impacted if DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED is false - integration-tests/cucumber/cucumber.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(44) } to not have property 'test.is_modified'
    
  • [email protected] commonJS impacted tests test is not new should not be detected as impacted if DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED is false - integration-tests/cucumber/cucumber.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(44) } to not have property 'test.is_modified'
    
  • [email protected] impacted tests test is not new should not be detected as impacted if DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED is false - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(46) } to not have property 'test.is_modified'
    
  • [email protected] impacted tests test is not new should not be detected as impacted if DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED is false - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(46) } to not have property 'test.is_modified'
    
  • playwright@latest impacted tests test is not new should not be detected as impacted if DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED is false - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(46) } to not have property 'test.is_modified'
    

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025

Benchmarks

Benchmark execution time: 2025-06-13 18:45:19

Comparing candidate commit f6e0f8f in PR branch mhlidd/test_Ci with baseline commit 2531473 in branch master.

Found 0 performance improvements and 12 performance regressions! Performance is the same for 1259 metrics, 52 unstable metrics.

scenario:log-skip-log-22

  • 🟥 cpu_user_time [+20.585ms; +27.131ms] or [+7.503%; +9.889%]
  • 🟥 execution_time [+27.610ms; +30.713ms] or [+8.107%; +9.018%]

scenario:log-with-debug-22

  • 🟥 cpu_user_time [+22.705ms; +28.414ms] or [+8.320%; +10.412%]
  • 🟥 execution_time [+28.402ms; +30.165ms] or [+8.337%; +8.854%]

scenario:log-with-error-22

  • 🟥 cpu_user_time [+19.311ms; +26.008ms] or [+7.213%; +9.714%]
  • 🟥 execution_time [+26.529ms; +29.825ms] or [+7.891%; +8.871%]

scenario:log-without-log-22

  • 🟥 cpu_user_time [+22.643ms; +28.208ms] or [+9.188%; +11.446%]
  • 🟥 execution_time [+27.415ms; +29.030ms] or [+8.685%; +9.197%]

scenario:spans-finish-immediately-18

  • 🟥 cpu_user_time [+33.880ms; +40.075ms] or [+5.812%; +6.874%]
  • 🟥 execution_time [+32.312ms; +38.191ms] or [+5.123%; +6.056%]
  • 🟥 instructions [+114.5M instructions; +120.1M instructions] or [+5.256%; +5.512%]

scenario:spans-finish-immediately-20

  • 🟥 cpu_user_time [+25.379ms; +31.014ms] or [+5.038%; +6.156%]

@mhlidd mhlidd force-pushed the mhlidd/test_Ci branch 2 times, most recently from 21bcc5a to 7399fdb Compare June 3, 2025 21:40
@mhlidd mhlidd force-pushed the mhlidd/test_Ci branch 2 times, most recently from cc86025 to 4ce82c4 Compare June 5, 2025 00:24
@mhlidd mhlidd force-pushed the mhlidd/test_Ci branch 2 times, most recently from 32bed79 to 7a58812 Compare June 6, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants