Skip to content

[DOCS-9810] Add lambda section to HTTP Server source doc #29222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 15, 2025
Merged

[DOCS-9810] Add lambda section to HTTP Server source doc #29222

merged 8 commits into from
May 15, 2025

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented May 7, 2025

What does this PR do? What is the motivation?

Adds instructions on sending AWS vended logs to OP.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner May 7, 2025 20:36
@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Preview links (active after the build_preview check completes)

Modified Files

@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 12, 2025
brett0000FF
brett0000FF approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few suggestions/comments.

content/en/observability_pipelines/sources/http_server.md Outdated
You can find the installed forwarder Lambda function under the stack's **Resources** tab with the logical ID `Forwarder`.

[Set up triggers][6] for the installed Datadog Forwarder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this should be included in the numbered list above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated.

ckelner
ckelner reviewed May 14, 2025
View reviewed changes
content/en/observability_pipelines/sources/http_server.md

1. In the **DdUrl** field, enter your load balancer address. Datadog recommends fronting your Worker with a load balancer.
1. In the **DdPort** field, enter `80`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should match the port from the "Set up a pipeline" step, so in the case of this example 9997

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

content/en/observability_pipelines/sources/http_server.md Outdated
1. In the **DdUrl** field, enter your load balancer address. Datadog recommends fronting your Worker with a load balancer.
1. In the **DdPort** field, enter `80`.
1. If you want to encrypt traffic from the Datadog Forwarder to your Observability Pipelines Worker load balancer, you need to create an HTTPS listener and manage a certificate on your load balancer. See [Create an HTTPS listener for your Application Load Balancer][5] for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is pedantic, but it is possible they don't setup their OPW in AWS, so perhaps when we reference the AWS docs we should say "For example in AWS...consult your cloud provider's documentation" or something that to that tune.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is meant for the next line, so I updated that.

@maycmlee
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-15 19:34:42 UTC ℹ️ Start processing command /merge

2025-05-15 19:34:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).

2025-05-15 19:54:45 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 711ab08 into master May 15, 2025
12 of 14 checks passed
@dd-mergequeue dd-mergequeue bot deleted the may/lambda-logs-http-server-source branch May 15, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckelner ckelner ckelner left review comments

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maycmlee @ckelner @brett0000FF