Skip to content

[SDTEST][NOTICKET] Update troubleshooting of Test Optimization #29394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

[SDTEST][NOTICKET] Update troubleshooting of Test Optimization #29394

merged 5 commits into from
May 19, 2025

Conversation

TovRudyy
Copy link
Contributor

Adding a new section to the Test Optimization troubleshooting.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@TovRudyy TovRudyy requested review from a team as code owners May 16, 2025 14:32
@TovRudyy TovRudyy requested a review from juan-fernandez May 16, 2025 14:32
@TovRudyy TovRudyy force-pushed the olek.rudyy/troubleshooting branch from 233b315 to a98e526 Compare May 16, 2025 14:33
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

janine-c
janine-c approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Olek! Because it's a troubleshooting topic, it can sometimes be useful to end with a recommendation to avoid seeing this behaviour - maybe something like "To ensure your tags display properly, space out your retries so each one has at least a second to complete," or whatever you think would be more technically correct than that 🙂

@TovRudyy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 07:53:12 UTC ℹ️ Start processing command /merge

2025-05-19 07:53:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-19 09:40:59 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@TovRudyy
Copy link
Contributor Author

Looks great, Olek! Because it's a troubleshooting topic, it can sometimes be useful to end with a recommendation to avoid seeing this behaviour - maybe something like "To ensure your tags display properly, space out your retries so each one has at least a second to complete," or whatever you think would be more technically correct than that 🙂

I discussed it with my team and we don't want to add such recommendation because it could confuse users more than helping them. We don't expect nobody to add a delay in their tests to mitigate the race condition.

@TovRudyy
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 09:40:54 UTC ℹ️ Start processing command /remove

2025-05-19 09:40:57 UTC ℹ️ Devflow: /remove

@TovRudyy TovRudyy removed the request for review from juan-fernandez May 19, 2025 09:41
@TovRudyy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 09:43:44 UTC ℹ️ Start processing command /merge

2025-05-19 09:43:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-19 10:12:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).

2025-05-19 10:29:59 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9bb26d8 into master May 19, 2025
16 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the olek.rudyy/troubleshooting branch May 19, 2025 10:29
brantigua pushed a commit that referenced this pull request May 19, 2025
@TovRudyy
[SDTEST][NOTICKET] Update troubleshooting of Test Optimization (#29394)
f7d27a8 
* Update troubleshooting of Test Optimization

* remove 'very'

* pr feedback

* pr feedback - remove possible mitigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyboltonking guyboltonking guyboltonking approved these changes

@janine-c janine-c janine-c approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TovRudyy @guyboltonking @janine-c @nikita-tkachenko-datadog