Skip to content

Create <Stepper /> component #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gazoon007
Copy link
Contributor

2025-07-25_00-41-27.mp4

Stepper component, feel free to give feedback.

I add logic when all steps are completed. The step indicator couldn't be clicked anymore

@DavidHDev
Copy link
Owner

DavidHDev commented Jul 25, 2025

Instead of hardcoding logic like that, add a prop called "disableOnComplete" instead, it gives more flexibility. The stepper won't always require user action, it could just be informational, so going back to certain states even after completing it might still be useful.

@Gazoon007
Copy link
Contributor Author

Gazoon007 commented Jul 25, 2025

Noted, will reevaluate the flexibility

Copy link
Owner

@DavidHDev DavidHDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@Gazoon007
Copy link
Contributor Author

I do think lockOnComplete is a more appropriate name (preventStepBackOnComplete or disableStepperOnComplete is also nice and much explicit, but it's a bit verbose).

Imo, disableOnComplete is ambiguous (it’s not clear what is being disabled).

Feel free to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants