Final Polishing core.py #396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also address issue #371 |
Pwhsky
reviewed
Aug 2, 2025
| def test_DeepTrackDataObject(self): | ||
| dataobj = core.DeepTrackDataObject() | ||
|
|
||
| # Test storing and validating data. | ||
| # Test default inititialization |
mirjagranfors
approved these changes
Aug 6, 2025
| >>> child.is_valid((0,)) | ||
| True | ||
| >>> grandchild.is_valid((0,)) | ||
| False | ||
|
|
||
| Setting a value and automatic invalidation: |
There was a problem hiding this comment.
When reading this comment, I expect to see something about the automatic invalidation in the example. But it is not obvious to me which data is automatically invalidated
|
|
||
| # Invalidate parent and check child validity. | ||
| parent.invalidate() | ||
| self.assertFalse(parent.is_valid()) | ||
| self.assertFalse(child.is_valid()) | ||
| self.assertFalse(grandchild.is_valid()) | ||
|
|
||
| # Validate parent and ensure child is invalid until recomputation. |
There was a problem hiding this comment.
I think that "# Validate child. Parent and grandchild remain invalid until recompute." would be clearer here
| child.validate() | ||
| self.assertFalse(parent.is_valid()) | ||
| self.assertTrue(child.is_valid()) | ||
| self.assertFalse(grandchild.is_valid()) | ||
|
|
||
| # Recompute child and check its validity |
There was a problem hiding this comment.
Here I would prefer "# Recompute grandchild and check its validity."
| " ┌────────────┐ ┌────────────┐\n", | ||
| " │ process1_B │ │ process2_B │\n", | ||
| " └────────────┘ └────────────┘\n", | ||
| " ↓ ↘ ↙ ↓\n", |
There was a problem hiding this comment.
I think that by removing 2 of the arrows in this row the figure would become clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.