Add arbitrary restart hour for UFS #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add hflx_fire, evap_fire, cpl_fire Co-authored-by: Grant Firl <[email protected]>
* restart_fh using shr_is_restart_fh_mod * Use is_restart_fh revised to avoid thread-local storage inter-component conflicts
|
@jedwards4b I'm not sure, but I might need an ifdef around the restart_fh logical in |
jedwards4b
requested changes
Dec 18, 2024
|
Yes that should be enough. |
|
I made a PR to ESCOMP/CDEPS to add the required module file. |
|
@jedwards4b Is this good to go? I forgot about, so completely understand if you did too. |
|
@jedwards4b I can't tell why this is failing the build check. It seems the line it's complaining about is inside a ifndef CESMCOUPLED. |
|
@DeniseWorthen I found the problem - you need to approve ESCOMP/CDEPS#330 so that the new share file is actually built and added to the library. |
jedwards4b
approved these changes
Mar 21, 2025
|
@jedwards4b Thanks for the coordination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Enables UFS to read a list of non-interval restart hours and write restarts when appropriate. This is required for operational implementations.
Incidentally adds new Land model component (LM4) for UFS and modifies CPP metadata for the FBH (fire-behavior model).
Specific notes
Code is added under an CESMCOUPLED flag and accesses share code within the UFS CDEPS share code (ufs/cdeps_share).
See related discussion https://github.com/orgs/esmf-org/discussions/291
Contributors other than yourself, if any:
@NickSzapiro-NOAA
CMEPS Issues Fixed (include github issue #):
ufs-community/ufs-weather-model#2348
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Should not impact CESM
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing