Skip to content

feat(localization): update pseudo translation #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v.next
Choose a base branch
from

Conversation

jona7150
Copy link
Collaborator

@jona7150 jona7150 commented Jul 3, 2025

Updated translation using Jenkins. Please review and merge @mstefarov @dotMorten

CC: @michi6571 @masa6674

@jona7150 jona7150 requested review from dotMorten and mstefarov July 3, 2025 19:34
@dotMorten
Copy link
Member

@jona7150 Thanks. Pseudo's look good, but we don't merge pseudo translations into our builds.

@jona7150
Copy link
Collaborator Author

jona7150 commented Jul 3, 2025

Added another commit for pseudo translation updates: 08ba1ff

@jona7150
Copy link
Collaborator Author

jona7150 commented Jul 3, 2025

Added another commit for pseudo translation updates: a752f8b

@michi6571
Copy link

@dotMorten, We have added 2 additional commits to this PR.

The initial commit did not include the BS and zh-HK files, so these have now been added. Additionally, we noticed that the pseudo place-hold markers in the AR file should not come from zh-CH or zh-TW, so we address another commit to correct the the pseudo place-hold markers for AR.

  1. 08ba1ff

  2. a752f8b

cc @mstefarov @masa6674

@jona7150
Copy link
Collaborator Author

Added another commit for translation updates: 1429814

@michi6571
Copy link

@mstefarov @dotMorten, The translation has been completed and checked in. Please find the new commit in this PR:
#668 (comment)

cc @masa6674

Copy link
Collaborator

@mstefarov mstefarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective, this looks complete and good to merge.

I have reviewed the translations in the languages that I know well. Russian has a couple issues that would be good to fix, but Ukrainian and German are good to go.

I wouldn't hold up this PR to fix those Russian issues, but it would be good to follow up with fixes later.

<value>Несохраненные изменения</value>
</data>
<data name="FeatureFormUtilityElementFractionAlongEdge" xml:space="preserve">
<value>Дробление вдоль ребра: {0}</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another misleading translation. Maybe the translator misread fraction as fracture, or mixed up "дробь" (mathematical fraction) with "дробление" (fragmentation). Either way, the final results here reads as "breakage along edge".

The clearest translation I can think of would be "Положение" (relative position).

Suggested change
<value>Дробление вдоль ребра: {0}</value>
<value>Положение вдоль ребра: {0}</value>

Comment on lines +432 to +446
<data name="FeatureFormPendingEditsApply" xml:space="preserve">
<value>Применить</value>
</data>
<data name="FeatureFormPendingEditsCancel" xml:space="preserve">
<value>Отмена</value>
</data>
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve">
<value>Да</value>
</data>
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve">
<value>Ошибка</value>
</data>
<data name="FeatureFormPendingEditsMessage" xml:space="preserve">
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Применить изменения?</value>
</data>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translated button label is misleading here:

  • A message box "FeatureFormPendingEditsMessage" asks the question "Применить изменения?" (Apply changes?)
  • The button "FeatureFormPendingEditsDiscard" is labeled "Да" (Yes) -- but this button actually discards changes.

I recommend correcting the button labels to "Сохранить" (Save/Apply) and "Не сохранять" (Don't save/Discard) instead. This would also align with standard wording used in other Esri products:

Suggested change
<data name="FeatureFormPendingEditsApply" xml:space="preserve">
<value>Применить</value>
</data>
<data name="FeatureFormPendingEditsCancel" xml:space="preserve">
<value>Отмена</value>
</data>
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve">
<value>Да</value>
</data>
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve">
<value>Ошибка</value>
</data>
<data name="FeatureFormPendingEditsMessage" xml:space="preserve">
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Применить изменения?</value>
</data>
<data name="FeatureFormPendingEditsApply" xml:space="preserve">
<value>Сохранить</value>
</data>
<data name="FeatureFormPendingEditsCancel" xml:space="preserve">
<value>Отмена</value>
</data>
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve">
<value>Не сохранять</value>
</data>
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve">
<value>Ошибка</value>
</data>
<data name="FeatureFormPendingEditsMessage" xml:space="preserve">
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Сохранить изменения сейчас?</value>
</data>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants