-
Notifications
You must be signed in to change notification settings - Fork 126
feat(localization): update pseudo translation #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v.next
Are you sure you want to change the base?
Conversation
@jona7150 Thanks. Pseudo's look good, but we don't merge pseudo translations into our builds. |
Added another commit for pseudo translation updates: 08ba1ff |
Added another commit for pseudo translation updates: a752f8b |
@dotMorten, We have added 2 additional commits to this PR. The initial commit did not include the BS and zh-HK files, so these have now been added. Additionally, we noticed that the pseudo place-hold markers in the AR file should not come from zh-CH or zh-TW, so we address another commit to correct the the pseudo place-hold markers for AR. |
Added another commit for translation updates: 1429814 |
@mstefarov @dotMorten, The translation has been completed and checked in. Please find the new commit in this PR: cc @masa6674 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a technical perspective, this looks complete and good to merge.
I have reviewed the translations in the languages that I know well. Russian has a couple issues that would be good to fix, but Ukrainian and German are good to go.
I wouldn't hold up this PR to fix those Russian issues, but it would be good to follow up with fixes later.
<value>Несохраненные изменения</value> | ||
</data> | ||
<data name="FeatureFormUtilityElementFractionAlongEdge" xml:space="preserve"> | ||
<value>Дробление вдоль ребра: {0}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another misleading translation. Maybe the translator misread fraction as fracture, or mixed up "дробь" (mathematical fraction) with "дробление" (fragmentation). Either way, the final results here reads as "breakage along edge".
The clearest translation I can think of would be "Положение" (relative position).
<value>Дробление вдоль ребра: {0}</value> | |
<value>Положение вдоль ребра: {0}</value> |
<data name="FeatureFormPendingEditsApply" xml:space="preserve"> | ||
<value>Применить</value> | ||
</data> | ||
<data name="FeatureFormPendingEditsCancel" xml:space="preserve"> | ||
<value>Отмена</value> | ||
</data> | ||
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve"> | ||
<value>Да</value> | ||
</data> | ||
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve"> | ||
<value>Ошибка</value> | ||
</data> | ||
<data name="FeatureFormPendingEditsMessage" xml:space="preserve"> | ||
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Применить изменения?</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translated button label is misleading here:
- A message box "FeatureFormPendingEditsMessage" asks the question "Применить изменения?" (Apply changes?)
- The button "FeatureFormPendingEditsDiscard" is labeled "Да" (Yes) -- but this button actually discards changes.
I recommend correcting the button labels to "Сохранить" (Save/Apply) and "Не сохранять" (Don't save/Discard) instead. This would also align with standard wording used in other Esri products:
<data name="FeatureFormPendingEditsApply" xml:space="preserve"> | |
<value>Применить</value> | |
</data> | |
<data name="FeatureFormPendingEditsCancel" xml:space="preserve"> | |
<value>Отмена</value> | |
</data> | |
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve"> | |
<value>Да</value> | |
</data> | |
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve"> | |
<value>Ошибка</value> | |
</data> | |
<data name="FeatureFormPendingEditsMessage" xml:space="preserve"> | |
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Применить изменения?</value> | |
</data> | |
<data name="FeatureFormPendingEditsApply" xml:space="preserve"> | |
<value>Сохранить</value> | |
</data> | |
<data name="FeatureFormPendingEditsCancel" xml:space="preserve"> | |
<value>Отмена</value> | |
</data> | |
<data name="FeatureFormPendingEditsDiscard" xml:space="preserve"> | |
<value>Не сохранять</value> | |
</data> | |
<data name="FeatureFormApplyEditsErrorTitle" xml:space="preserve"> | |
<value>Ошибка</value> | |
</data> | |
<data name="FeatureFormPendingEditsMessage" xml:space="preserve"> | |
<value>Вам необходимо подтвердить или отменить изменения для текущего объекта. Сохранить изменения сейчас?</value> | |
</data> |
Updated translation using Jenkins. Please review and merge @mstefarov @dotMorten
CC: @michi6571 @masa6674