yang: Correct pyang errors in frr-bgp-route-map.yang #18781
Conversation
yang/frr-bgp-route-map.yang
Outdated
| case distance { | ||
| when "derived-from-or-self(../frr-route-map:action, 'frr-bgp-route-map:distance')"; | ||
| leaf distance { | ||
| type uint8 { | ||
| range "1..255"; | ||
| } | ||
| description | ||
| "Set the OSPF distance for the route"; |
There was a problem hiding this comment.
Maybe just say "the distance" (i.e., leave off OSPF).
There was a problem hiding this comment.
Maybe just say "the distance" (i.e., leave off OSPF).
Hello Christian Hopps,
Addressed review comment.
Thanks & Regards,
Bharath
yang/frr-bgp-route-map.yang
Outdated
| @@ -980,13 +1043,17 @@ identity set-extcommunity-color { | |||
| "Set the IPv4 address"; | |||
| leaf ipv4-address { | |||
| type inet:ipv4-address; | |||
| description | |||
| "Specifies the IPv4 address for BGP routes"; | |||
There was a problem hiding this comment.
I think for each of these cases with a single leaf value, the description on the case is (or should be) "Set the XXX", and the description on the leaf should then be "Specifies the XXX value". So in this case the description should be Specifies the IPv4 address value. Apply this to each of the following case/leafs below.
There was a problem hiding this comment.
I think for each of these cases with a single leaf value, the description on the case is (or should be) "Set the XXX", and the description on the leaf should then be "Specifies the XXX value". So in this case the description should be
Specifies the IPv4 address value. Apply this to each of the following case/leafs below.
Hello Christian Hopps,
Addressed review comments.
Thanks & Regards,
Bharath
y-bharath14
force-pushed
the
srib-yang-v13
branch
from
a8e3e1b to
e6ddb35
Compare
y-bharath14
force-pushed
the
srib-yang-v13
branch
from
e6ddb35 to
676cc5e
Compare
|
ci:rerun |
Correct pyang errors or warnings in frr-bgp-route-map.yang Signed-off-by: y-bharath14 <[email protected]>
y-bharath14
force-pushed
the
srib-yang-v13
branch
from
676cc5e to
72cbdd4
Compare
|
@ton31337 are you good now? |
|
yes, I approved already. |
Correct pyang errors or warnings in frr-bgp-route-map.yang