Upgrade FastDoubleParser to 2.0.1
#1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like we should probably only include LTS-matched classes, so leave JDK 21 but drop 23. |
|
This is currently blocked. maven-shade-plugin is omitting some new subpackages from FastDoubleParser. I have tried a few changes to the config setup but the classes are still missing so far. |
|
The issue seems that the We could merge this and if anything breaks in other Jackson builds, we could revert this. |
pom.xml
Outdated
| @@ -175,6 +175,7 @@ com.fasterxml.jackson.core.*;version=${project.version} | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-shade-plugin</artifactId> | |||
| <version>3.6.0</version> | |||
There was a problem hiding this comment.
Not needed, should come from "oss-parent", will remove.
cowtowncoder
changed the title
FastDoubleParser to 2.0.1
|
Sure, I can merge this now and we can see what (if anything) happens downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastDoubleParser) #1447 is dealt withFastDoubleParser) #1447 to match what is in fastdoubleparser 2.0.1 (this jar has Java 23 classes but no Java 22 ones)