feat: Allow accepting a JSON substring using a string instead of throwing an exception. #5232
Conversation
|
Can you add related github issue? |
|
|
|
||
| @Test | ||
| public void acceptSubJsonTest() throws Exception { | ||
| String json = "{\"name\":\"root\"," + |
There was a problem hiding this comment.
- use the method a2q which converts apostrophes to double quotes
- the text then should use apostrophes instead of quotes - the advantage is that you don't need to escape apostrophes making the text easier to read
- example -
| * Feature that allow accepting a JSON substring using a string | ||
| * instead of throwing an exception. | ||
| *<p> | ||
| * Feature is enabled by default. |
There was a problem hiding this comment.
this is disabled by default - so the comment is wrong
Create a new issue for discussion. I would suggest not spending more time on the implementation until there is agreement that we want to add a feature like this. |
|
@pjfanning I have created a new issue to discuss this feature. |
| @@ -19,6 +19,12 @@ | |||
| import com.fasterxml.jackson.databind.jsontype.TypeDeserializer; | |||
| import com.fasterxml.jackson.databind.type.LogicalType; | |||
|
|
|||
| import java.io.IOException; | |||
There was a problem hiding this comment.
Please do not re-order or expand import statements. Lots of noise & something we'll revert over time anyway.
|
As things are this would not be accepted: it's a very specialized case that does not fit well with Jackson modeling. For your use case I would write a custom |
| return defaultDeserialize(p, ctxt); | ||
| } | ||
|
|
||
| StringBuilder builder = new StringBuilder(); |
There was a problem hiding this comment.
Ugh. This is madness... are we trying to re-construct JSON BACK from decoded JSON?
No, I don't think this is something to add.
(for #5233)
This PR implementation allows the use of a string to accept a JSON substring during deserialization.
And provided unit testing for verification, as well as backward compatibility.