Fix #5238 #5239
Fix #5238 #5239
Conversation
src/test-jdk17/java/com/fasterxml/jackson/databind/records/JsonIdentityOnRecord5328Test.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java
Outdated
Show resolved
Hide resolved
| public final String name; | ||
|
|
||
| @JsonCreator | ||
| public ThingPojo(@JsonProperty("id") int id, @JsonProperty("name") String name) { |
There was a problem hiding this comment.
I think this test should make sure id is only set via Constructor and NOT direct set on Field.
(JVM does allow forced settting of final Fields).
One way would be to make constructor change "id" value by prefix or suffix.
I know the end result does not look different, but it would explain discrepancy.
| @@ -335,7 +336,12 @@ public Object handleIdValue(final DeserializationContext ctxt, Object bean) thro | |||
| // also: may need to set a property value as well | |||
| SettableBeanProperty idProp = _objectIdReader.idProperty; | |||
| if (idProp != null) { | |||
| return idProp.setAndReturn(bean, _idValue); | |||
| // [databind#5328] Records do not have setters, skip...to set id value | |||
| if (ClassUtil.isRecordType(bean.getClass())) { | |||
There was a problem hiding this comment.
I'll have to think about this: ideally, setAndReturn() would not be called because id was passed via Constructor and no check was needed here.
Or maybe check could be done that if idProp is a CreatorProperty, no call would be made?
This is related to ensuring that we also do not try forcibly setting Field in regular POJO case, if id was already passed via Creator (see my note on test class).
No description provided.