-
Notifications
You must be signed in to change notification settings - Fork 398
Make base address space abstract #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hon-version for pyenv
…rity and consistency in method signatures
…ailures when loading shelf files
… virtual environments
…rt for python <3.10
fine but I think these changes should be a few commits. one for each new abstract classes. Not 19 with some random rebases |
aha yeah -- sorry! will try to tidy up my branches before opening the next PR :) |
to be honest I am afraid of all these changes. A lot of chnages that makes code harder to follow and the use case is not really clear for me. |
@oroulet intent was to allow for any user-implemented address space, and provide better type hinting for iserver/associated services... e.g. perhaps make an address space using redis or mongodb backend... would allow for much better data persistence + provide much better redundancy (and a more natural space for tag history to be stored). I can provide an implemented example shortly... are there specific speed/performance tests that you have in mind? e.g. just tag reads/writes? |
adding abstract classes for user manager, address space in order to allow for better implementation of iserver instantiation (allow iserver to use custom address space class)