Skip to content

Make base address space abstract #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

pbouill
Copy link

@pbouill pbouill commented Apr 15, 2025

adding abstract classes for user manager, address space in order to allow for better implementation of iserver instantiation (allow iserver to use custom address space class)

pbouill and others added 19 commits April 11, 2025 15:13
@oroulet
Copy link
Member

oroulet commented Apr 22, 2025

fine but I think these changes should be a few commits. one for each new abstract classes. Not 19 with some random rebases

@pbouill
Copy link
Author

pbouill commented Apr 22, 2025

aha yeah -- sorry! will try to tidy up my branches before opening the next PR :)

@pbouill
Copy link
Author

pbouill commented Apr 30, 2025

@oroulet -- do you want me to close this PR? These changes are included in #1835

@oroulet
Copy link
Member

oroulet commented May 5, 2025

to be honest I am afraid of all these changes. A lot of chnages that makes code harder to follow and the use case is not really clear for me.
Also what are the impact on performamce on all the calls redirections?

@oroulet oroulet closed this May 5, 2025
@pbouill
Copy link
Author

pbouill commented May 8, 2025

@oroulet intent was to allow for any user-implemented address space, and provide better type hinting for iserver/associated services... e.g. perhaps make an address space using redis or mongodb backend... would allow for much better data persistence + provide much better redundancy (and a more natural space for tag history to be stored). I can provide an implemented example shortly... are there specific speed/performance tests that you have in mind? e.g. just tag reads/writes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants