Skip to content

bugfix/web_encoding: fix web specific encoding issue #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mooyeee
Copy link

@Mooyeee Mooyeee commented Mar 23, 2025

This PR solves an encoding issue encountered on web where some special accented characters (i.e. èéàùìò) would translate to \uFFFD (�) which would make the app crash when trying to log it to the web console.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d8d68ca) to head (c1f8d42).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #348      +/-   ##
===========================================
+ Coverage   98.45%   100.00%   +1.54%     
===========================================
  Files          28         8      -20     
  Lines         583        66     -517     
===========================================
- Hits          574        66     -508     
+ Misses          9         0       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Frezyx Frezyx requested a review from Copilot May 2, 2025 07:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/talker_logger/lib/src/logger_web.dart: Language not supported

@Frezyx Frezyx added web Related to Flutter web, WASM and JS interop awaiting On the list for consideration or merge labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting On the list for consideration or merge web Related to Flutter web, WASM and JS interop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants