feat: Add functions to connect well perforation to surface elements #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CusiniM, @castelletto1, @jhuang2601, @rrsettgast please review |
CusiniM
reviewed
Mar 2, 2025
Comment on lines
240
to
243
| elemManager.forElementSubRegions< CellElementSubRegion, FaceElementSubRegion >( [&] ( auto const & subRegion ) | ||
| { | ||
| subRegion.calculateElementCenters( X ); | ||
| } ); |
There was a problem hiding this comment.
I find a bit weird that a function in FaceManager called computeGeometry takes care of computed element centers of the subregions. Also, do the fracture elements even exist at this point? I am assuming this occurs way before the event loop in which the surfacegenerator creates the fractures.
CusiniM
reviewed
Mar 2, 2025
| dy = boxDims[ 1 ]; | ||
| dz = boxDims[ 2 ]; | ||
|
|
||
| if( dx < 1e-10 ) |
There was a problem hiding this comment.
what's the meaning of this value?
CusiniM
reviewed
Mar 2, 2025
| (point[0] <= std::max( p1[0], p2[0] ))) | ||
| { | ||
| real64 const xIntersect = (point[1] - p1[1]) * (p2[0] - p1[0]) / (p2[1] - p1[1]) + p1[0]; | ||
| if( std::abs( p1[0] - p2[0] ) < 1e-10 || point[0] <= xIntersect ) |
There was a problem hiding this comment.
the tolerance seems a bit arbitrary, doesn't it?
CusiniM
reviewed
Mar 2, 2025
| } | ||
|
|
||
| // remove duplicates | ||
| std::unordered_set< Point3d, PointHash< Point3d >, PointsEqual< Point3d > > |
There was a problem hiding this comment.
why would there be duplicates? is it because of the duplicated nodes?
paveltomin
added
the
ci: run integrated tests
paveltomin
added
flag: no rebaseline
paveltomin
removed
the
ci: run integrated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should go after #3227
calculateElementCentersfor subregions earlier intoProblemManager::generateMeshLevel, so cell centers for surface elements are available when well perforation is processedregisterWrapperforelementCenterandelementVolumeinEmbeddedSurfaceSubRegion, they already registered in the base classgetReservoirElementDimensions/getBoundingBoxto supportSurfaceElementSubRegionSurfaceElementSubRegionversion ofisPointInsideElementand helper functionsisPointInPolygon2d/3d(not super refined implementation but something to start working with)