Workaround to make firework boost controlled by server. #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

oryxel1 wants to merge 1 commit into GeyserMC:master from oryxel1:firework-boost

Contributor

oryxel1 commented May 31, 2025

Does what it said, resolve #5409


          Workaround to make firework boost controlled by server.

30799fb

Contributor Author

oryxel1 commented May 31, 2025

Here if you want to see it:
https://github.com/user-attachments/assets/b0a32a2a-f8ad-4fcf-b70b-52921cffd885

Member

onebeastchris commented May 31, 2025

Thanks for the PR! I just tested it locally too.. not going to lie, this looks pretty rough :/
Some other issues the teleport introduces:

spamming rockets make it possible to remain still in the air
firework trail particles won't be shown

Honestly, i'm unsure if these trade-offs are worth it

Contributor Author

oryxel1 commented Jun 1, 2025

Closed for now.

oryxel1 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet