-
Notifications
You must be signed in to change notification settings - Fork 4k
Implement basic URL scheme for Assistant & AI Search #3503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0c09e49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This reverts commit 6d99b32.
So that the case of `q=` and `ask=` is handled correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Maybe we should add couple more E2E tests for the behavior. for ex - type in search bar -> click Assistant icon -> should open the AI chat etc
Thanks Taran, I added a bunch of tests now 😄 |
?q=
always dictates the search state?ask=
always dictates the AI Search / AI Assistant state.q=query&ask=true
→ask=query&q=null