Skip to content

Implement basic URL scheme for Assistant & AI Search #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 29, 2025

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Jul 24, 2025

  • Reshapes the query parameters previously used for Search & Ask AI to work for all three: search, AI Search, and AI Assistant.
  • ?q= always dictates the search state
  • ?ask= always dictates the AI Search / AI Assistant state.
  • You can switch between the two.
  • Both parameters now accept a string. When they are present in the URL without a string, the respective component is opened on the blank state. When there is a string present, it's used to pre-fill.
  • Added a rewrite for legacy URLs q=query&ask=trueask=query&q=null

Copy link

linear bot commented Jul 24, 2025

Copy link

changeset-bot bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: 0c09e49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Jul 29, 2025, 1:32 PM
v2-cloudflare (Inspect) 👍 Changes approved 16 added, 8 removed Jul 29, 2025, 1:37 PM
v2-vercel (Inspect) 👍 Changes approved 16 added, 8 removed Jul 29, 2025, 1:33 PM

So that the case of `q=` and `ask=` is handled correctly
Copy link
Member

@taranvohra taranvohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Maybe we should add couple more E2E tests for the behavior. for ex - type in search bar -> click Assistant icon -> should open the AI chat etc

@zenoachtig
Copy link
Contributor Author

Code looks good to me. Maybe we should add couple more E2E tests for the behavior. for ex - type in search bar -> click Assistant icon -> should open the AI chat etc

Thanks Taran, I added a bunch of tests now 😄

@zenoachtig zenoachtig merged commit b1f608b into main Jul 29, 2025
16 checks passed
@zenoachtig zenoachtig deleted the zeno/rnd-7715-basic-url-scheme branch July 29, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants