Skip to content

Upgrade the getrandom dependency of gix-diff #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Upgrade the getrandom dependency of gix-diff #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d229adb
Add `gix-diff` WASM check, even though `gix-path` covers it
EliahKagan Aug 2, 2025
32b6408
Bump `gix-diff` dependency `getrandom` to 0.3.3
EliahKagan Aug 2, 2025
06bc85b
Use `wasm_js` feature of `getrandom` in `gix-diff`
EliahKagan Aug 2, 2025
8f1173d
Enable `wasm_js` backend on CI where needed
EliahKagan Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,12 +457,14 @@ jobs:
for feature in progress parallel io-pipe crc32 zlib cache-efficiency-debug; do
cargo build -p gix-features --features "$feature" --target "$TARGET"
done
- name: Enable wasm_js backend
if: matrix.target == 'wasm32-unknown-unknown'
run: echo RUSTFLAGS='--cfg getrandom_backend="wasm_js"' >> "$GITHUB_ENV"
- name: crates with 'wasm' feature
run: |
set -x
for crate in gix-pack; do
cargo build -p "$crate" --features wasm --target "$TARGET"
done
cargo build -p gix-diff --no-default-features --features wasm --target "$TARGET"
cargo build -p gix-pack --features wasm --target "$TARGET"
- name: gix-pack with all features (including wasm)
run: cargo build -p gix-pack --all-features --target "$TARGET"

Expand Down
18 changes: 9 additions & 9 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gix-diff/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ gix-traverse = { version = "^0.47.0", path = "../gix-traverse", optional = true
thiserror = "2.0.0"
imara-diff = { version = "0.1.8", optional = true }
serde = { version = "1.0.114", optional = true, default-features = false, features = ["derive"] }
getrandom = { version = "0.2.8", optional = true, default-features = false, features = ["js"] }
getrandom = { version = "0.3.3", optional = true, default-features = false, features = ["wasm_js"] }
bstr = { version = "1.12.0", default-features = false }

document-features = { version = "0.2.0", optional = true }
Expand Down
Loading