exposing num threads as option #2349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key parallelism is limited by NUM_THREADS which is hardcoded to 100 [1]. This could cause commit too large exceptions [2].
Exposing this option for users to tweak is a easy workaround before implementing a long-term solution that ensures that it never generates outputs that are too large.
[1]
https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/datastream-to-sql/src/main/java/com/google/cloud/teleport/v2/transforms/CreateDml.java#L44
[2] https://cloud.google.com/dataflow/docs/guides/common-errors#key-commit-too-large-exception.