-
Notifications
You must be signed in to change notification settings - Fork 1.8k
docs(bigquery): initial preview samples #5347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a comprehensive set of initial code samples for the pre-alpha BigQuery Cloud Client Library in Go. These samples are designed to help developers quickly get started with basic client interactions and common dataset management tasks, while also ensuring all project dependencies are up-to-date.
Highlights
- New BigQuery Preview Samples: Added initial code snippets targeting the pre-alpha BigQuery Cloud Client Library for Go, demonstrating fundamental interactions with BigQuery.
- Client Usage Examples: Introduced a sample (
bigquery_client_usage.go
) showcasing how to instantiate BigQuery clients using both gRPC and REST transports, and how to list datasets and tables. - Dataset Management Samples: Provided new samples for common BigQuery dataset operations, including creating (
bigquery_create_dataset.go
), deleting (bigquery_delete_dataset.go
), listing (bigquery_list_datasets.go
), and updating (bigquery_update_dataset.go
) datasets, with appropriate error handling and best practices like optimistic concurrency control. - Dependency Updates: Updated various Go module dependencies in
go.mod
andgo.sum
to newer versions, including core Google Cloud libraries and OpenTelemetry components, to support the new BigQuery client library.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a solid set of initial code samples for the preview BigQuery Cloud Client Library. The examples are well-structured, covering basic client usage and essential dataset operations like creation, deletion, listing, and updating. The code is clear and provides valuable demonstrations of the new library's features.
// Changing DefaultTableExpirationMs does not affect existing tables in the | ||
// dataset, but newly created tables will inherit this as defaults. | ||
DefaultTableExpirationMs: &wrapperspb.Int64Value{ | ||
Value: 90 * 86400 * 1000, // 90 days in milliseconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value 86400
is a magic number representing the number of seconds in a day. To improve readability and maintainability, it's better to show the calculation explicitly. This makes the origin of the number clear without relying solely on the comment.
Value: 90 * 86400 * 1000, // 90 days in milliseconds. | |
Value: 90 * (24 * 60 * 60 * 1000), // 90 days in milliseconds. |
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
This PR adds some initial snippets that target the pre-alpha BigQuery Cloud Client Library.