-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(pubsub/v2): add single message transform samples #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hongalex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds new Go code samples for Google Cloud Pub/Sub, specifically demonstrating the use of Single Message Transforms (SMT). The samples illustrate how to configure SMTs on both topics and subscriptions, providing a concrete example of data redaction using a JavaScript UDF, and are integrated with system tests to validate their functionality.
Highlights
- New Samples for Single Message Transforms (SMT): Introduced new Go code samples demonstrating how to apply Single Message Transforms (SMT) to Google Cloud Pub/Sub topics and subscriptions.
- v2 Client Library Adoption: The new samples are built using the
cloud.google.com/go/pubsub/v2
client library, aligning with the latest API versions. - JavaScript UDF Example: The SMT examples showcase a practical use case: redacting sensitive data (SSN) from messages using an inline JavaScript User-Defined Function (UDF).
- System Tests: Accompanying system tests have been added for both topic and subscription SMT creation to ensure the samples function correctly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds samples for creating Pub/Sub topics and subscriptions with Single Message Transforms (SMT). The changes look good overall, but I've found a few issues. There's a critical bug in the subscription creation sample where the subscription name isn't being set, which will cause it to fail. I also found a potential panic in one of the tests due to incorrect error handling. Additionally, I've included suggestions to improve test robustness and code consistency.
Migrates the existing v1 SMT samples to use the v2 library.