Skip to content

chore(codeowners): add CODEOWNERS file and folder structure for model armor snippets #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rudrakhsha-crest
Copy link

@rudrakhsha-crest rudrakhsha-crest commented Mar 19, 2025

Description

Added CODEOWNERS file and folder strucutre for model armor node js code snippets.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@rudrakhsha-crest rudrakhsha-crest requested review from a team as code owners March 19, 2025 13:37
Copy link

google-cla bot commented Mar 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rudrakhsha-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds a CODEOWNERS file and sets up the folder structure for Node.js snippets related to the 'modelarmor' API. It also updates the .github/blunderbuss.yml file to include the modelarmor API, ensuring that relevant issues and pull requests are automatically assigned to the appropriate team.

Highlights

  • CODEOWNERS: The CODEOWNERS file is updated to include the model-armor directory, assigning ownership to @GoogleCloudPlatform/nodejs-samples-reviewers, @GoogleCloudPlatform/cloud-samples-reviewers, and @GoogleCloudPlatform/cloud-modelarmor-team.
  • Blunderbuss Configuration: The .github/blunderbuss.yml file is modified to automatically assign issues and pull requests labeled with api: modelarmor to the GoogleCloudPlatform/cloud-modelarmor-team.
  • New Package: A new model-armor directory is created, including a package.json file that defines the dependencies and scripts for the Node.js Model Armor samples.

Changelog

  • .github/blunderbuss.yml
    • Added configuration to assign issues and pull requests with the api: modelarmor label to the GoogleCloudPlatform/cloud-modelarmor-team.
    • Added configuration to assign pull requests with the api: modelarmor label to the GoogleCloudPlatform/cloud-modelarmor-team.
  • CODEOWNERS
    • Added model-armor entry to assign ownership to @GoogleCloudPlatform/nodejs-samples-reviewers, @GoogleCloudPlatform/cloud-samples-reviewers, and @GoogleCloudPlatform/cloud-modelarmor-team.
  • model-armor/package.json
    • Created a new package.json file for the model-armor samples, defining dependencies such as @google-cloud/modelarmor and development dependencies for testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

The YAML file format, used in .github/blunderbuss.yml, was initially called 'Yet Another Markup Language,' but it was later rebranded as 'YAML Ain't Markup Language' to emphasize its data-oriented purpose.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a CODEOWNERS entry and folder structure for the new model-armor samples. The changes look good overall, and the addition of the CODEOWNERS entry and the package.json file are necessary for the new samples. However, I have a few suggestions for improvement.

Summary of Findings

  • Missing test files: The model-armor directory is missing test files. It's important to add tests to ensure the code functions as expected.

Merge Readiness

The pull request is almost ready for merging. However, the model-armor directory is missing test files, which should be added before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

@rudrakhsha-crest rudrakhsha-crest force-pushed the model-armor-node-codeowners branch from 78945e7 to 525d9bf Compare March 20, 2025 15:12
@rudrakhsha-crest rudrakhsha-crest changed the title Added CODEOWNERS file and folder structure for nodejs snippets chore(codeowners): add CODEOWNERS file and folder structure for Node.js snippets Mar 20, 2025
@iennae
Copy link
Contributor

iennae commented Mar 20, 2025

Hey @rudrakhsha-crest are you a Googler creating this? Just trying to figure out how to reach out about the CLA failing. Thanks.

@rudrakhsha-crest rudrakhsha-crest changed the title chore(codeowners): add CODEOWNERS file and folder structure for Node.js snippets chore(codeowners): add CODEOWNERS file and folder structure for model armor snippets Mar 21, 2025
@rudrakhsha-crest
Copy link
Author

Hey @rudrakhsha-crest are you a Googler creating this? Just trying to figure out how to reach out about the CLA failing. Thanks.

Nope, I think the issue with CLA has been resolved now that I ammended that commit.

@glasnt glasnt self-assigned this Mar 25, 2025
@glasnt
Copy link
Contributor

glasnt commented Mar 25, 2025

Team added to repo, resolving CODEOWNERS validation error

@glasnt
Copy link
Contributor

glasnt commented Mar 25, 2025

Tests will not pass because of the forked repo, but there are currently no tests to run :)

@glasnt
Copy link
Contributor

glasnt commented Mar 25, 2025

Snippet Bot/tag issues b/406323821

@rudrakhsha-crest
Copy link
Author

rudrakhsha-crest commented Mar 28, 2025

I have raised a new PR containing snippets along with tests to solve the issue. Link
We can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants