-
-
Notifications
You must be signed in to change notification settings - Fork 824
Improve the Path tool's segment editing mode #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
#2860 (comment) |
Can you please explain the idea behind the |
I first did it purely in backend only, so these were the two approaches that I tried -
Hence I decided to make a flag |
Can you go back to the approach from your second bullet point, where it briefly flashes as disabled? We can live with that for the moment. What I need to do is adapt the UI design system to better accommodate the similarities ranging from checkboxes to radio buttons so they can share certain parts of their behavior, as needed here. The little flaw can be fixed at that time. |
|
@@ -1645,14 +1764,72 @@ impl Fsm for PathToolFsmState { | |||
}; | |||
|
|||
let quad = tool_data.selection_quad(document.metadata()); | |||
let polygon = &tool_data.lasso_polygon; | |||
|
|||
// TODO: Calculate which points/ handles are currently in the selected region and make those have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete comment sentence
I pushed my code review tweaks. I'll mark this as a draft while waiting the other requests in today's comments above. We're close on this one now! |
Closes #2832