-
-
Notifications
You must be signed in to change notification settings - Fork 823
Re-add upload texture #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Re-add upload texture #2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7419875
to
dd02569
Compare
8a0d5ab
to
45596c0
Compare
df9e2e1
to
bd8eb59
Compare
Keavon
reviewed
Jul 23, 2025
bd8eb59
to
76a0b7f
Compare
d5ab491
to
f3c3a56
Compare
Merged
TrueDoctor
approved these changes
Jul 24, 2025
f3c3a56
to
ef54629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively just 3 commits without dependent PRs:
context.resource_overrides
HashMapTexture upload node
TLDR: With @TrueDoctor we decided that SRGB8 for now is fine, but we would like to switch to f32 later and add a conversion step down to SRGB8 before we give it to vello.
We would like to have linear f32 textures, as discussed with @TrueDoctor. However, this implementation currently uses
Rgba8UnormSrgb
converted to with graphite'sSRGB8
struct, as usingRgba32Float
causes FF nightly to emitUncaptured WebGPU error: In a pass parameter, caused by: Encoder is invalid
. The real fun will be debugging that, since wgpu documents the error like this:https://github.com/gfx-rs/wgpu/blob/9b966bf8a39b07bfc495fb43e8bf7725c5df440c/wgpu-core/src/command/mod.rs#L971-L976
In other words, I have no clue to go on what's going wrong. Changing the image format shouldn't have triggered anything really. The only thing I can think of is the image format being unsupported for sampling, I'd have to verify this later. At least vulkan says I very much can with my hardware.