This repository was archived by the owner on Nov 10, 2018. It is now read-only.
ENH Load CSV files from different dialects #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose parameters of pyspark's CSV reader: sep, escape and multiLine.
gmichalo
suggested changes
Aug 3, 2018
|
@gmichalo thanks, I've changed the base branch and resolved the conflicts. |
gmichalo
suggested changes
Aug 4, 2018
holoclean/utils/reader.py
Outdated
|
|
||
| :return: dataframe | ||
| """ | ||
| try: | ||
| if schema is None: | ||
| df = spark_session.read.csv(file_path, header=True) | ||
| df = spark_session.read.csv(file_path, header=True, sep=sep, | ||
| escape=escape, multiLine=multiLine)) |
There was a problem hiding this comment.
One of the two parenthesis needs to be removed
holoclean/utils/reader.py
Outdated
| df = spark_session.read.csv(file_path, header=True, schema=schema) | ||
| df = spark_session.read.csv(file_path, header=True, schema=schema, | ||
| sep=sep, escape=escape, | ||
| multiLine=multiLine)) |
There was a problem hiding this comment.
One of the two parenthesis needs to be removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes some parameters of pyspark's CSV reader: sep, escape and multiLine, up to
session.load_data.This enables to load files in various dialects of CSV.