Skip to content

k6: pin go version to 1.23 #204322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

k6: pin go version to 1.23 #204322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a763dcd
k6: pin go version to 1.23
mstoykov Jan 15, 2025
a5dcb2f
test
mstoykov Jan 15, 2025
99b4cfa
Update Formula/k/k6.rb
mstoykov Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Formula/k/k6.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class K6 < Formula
sha256 cellar: :any_skip_relocation, x86_64_linux: "6c59c33536818d69e337bd36ce5b3e58054a019260d35027efae3b50ca7b56a5"
end

depends_on "go" => :build
depends_on "go@1.23" => :build # See https://github.com/grafana/k6/issues/2699 and https://github.com/grafana/k6/issues/2474
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

* Dependency '[email protected]' is an alias; use the canonical name 'go'.

this might need to wait after #201070

Copy link
Author

@mstoykov mstoykov Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not pin the latest version we need to pin to an old one if we want ?


def install
system "go", "build", *std_go_args(ldflags: "-s -w")
Expand Down
Loading