fix: BROS-193: Follow up fixes #8057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anything changed
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8057 +/- ##
===========================================
- Coverage 70.37% 65.89% -4.48%
===========================================
Files 719 505 -214
Lines 51023 33494 -17529
Branches 8621 8621
===========================================
- Hits 35906 22070 -13836
+ Misses 15114 11421 -3693
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
StorageProviderFormand related components, focusing on improving edit mode handling, validation logic, and error display. Key changes include enhancements to provider configuration, the addition of debug logging, and adjustments to schema handling for optional fields.Improvements to edit mode handling:
web/libs/app-common/src/blocks/StorageProviderForm/hooks/useStorageForm.ts: Added logic to wait for provider registry initialization and debug logging for missing provider configurations in edit mode. Updated form data initialization to handle optional fields more robustly. [1] [2] [3]web/libs/app-common/src/blocks/StorageProviderForm/index.tsx: Updatedtypestate initialization to use storage type or provider in edit mode. Added synchronization offormData.providerwithtypein edit mode. [1] [2]Validation and schema enhancements:
web/libs/app-common/src/blocks/StorageProviderForm/types/provider.ts: Adjusted schema generation to make optional fields nullable and optional, improving handling of null values from the server.web/libs/app-common/src/blocks/StorageProviderForm/hooks/useStorageForm.ts: Simplified validation reset logic to trigger on any field change instead of specific connection fields.Error handling and display improvements:
web/libs/app-common/src/blocks/StorageProviderForm/index.tsx: Added anInlineErrorcomponent for better error visibility in the form UI.web/libs/app-common/src/blocks/StorageProviderForm/components/field-renderer.tsx: Updated error-related CSS class to use a more descriptive name (border-negative-content).Provider configuration updates:
web/libs/app-common/src/blocks/StorageProviderForm/providers.ts: Ensured provider names are stored in lowercase in the registry for consistency.web/libs/app-common/src/blocks/StorageProviderForm/hooks/useStorageForm.ts: Added support for theproviderRegistryto manage dynamic provider configurations.Removed redundant code:
web/libs/app-common/src/blocks/StorageProviderForm/Steps/preview-step.tsx,provider-details-step.tsx: Removed unusedInlineErrorimports and instances. [1] [2] [3] [4]web/libs/app-common/src/blocks/StorageProviderForm/components/provider-grid.stories.tsx: Removed outdated Storybook stories forProviderGrid.